[PATCH] D116497: Make separate config variable for `LLVM_LIBRARY_DIRS`
John Ericson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Jan 2 11:11:06 PST 2022
Ericson2314 created this revision.
Ericson2314 added a reviewer: beanz.
Herald added a subscriber: mgorny.
Ericson2314 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
@beanz tells me it should in fact exists, and it would be bad to put a
list of dirs in `LLVM_LIBRARY_DIR`. I am therefore making some changes
to help avoid this an other mistakes:
- Use a separate `LLVM_CONFIG_LIBRARY_DIR` (no "S") variable so we don't start putting a list in `LLVM_LIBRARY_DIR` by mistake.
- Define the individual dir variables first, and the define the list of dirs variables programmatically.
Also, I rearranged the definitions of the "regular" single dirs below so
`LLVM_BINARY_DIR`, which is the unsuffixed one, comes first before the
suffixed ones.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D116497
Files:
llvm/cmake/modules/CMakeLists.txt
llvm/cmake/modules/LLVMConfig.cmake.in
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116497.396939.patch
Type: text/x-patch
Size: 4389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220102/982addda/attachment.bin>
More information about the llvm-commits
mailing list