[PATCH] D116496: [unroll] Prune all but first copy of invariant exit

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 2 10:02:38 PST 2022


reames added a comment.

In D116496#3216380 <https://reviews.llvm.org/D116496#3216380>, @nikic wrote:

> This generally makes sense to me, but I think you need to adjust some of the tests to make the condition non-invariant, because I doubt that this is what they were intending to test. Replace an argument with a call return value.

Did you have any particular tests in mind?  I skimmed the tests and don't see any where the change obviously breaks intent of the test author.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116496/new/

https://reviews.llvm.org/D116496



More information about the llvm-commits mailing list