[PATCH] D116267: [DSE] Check for whole object overwrite even if dead store size not known

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jan 2 09:34:00 PST 2022


reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM, and thanks for following up on my observation on the other review.

The old code would leave around a write larger than the object size even if the entire object was killed later.  That in theory would let us discover the UB, but I think that was purely an accident in the code.  We could explicitly handle the UB case before checking for deadness if desired.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116267/new/

https://reviews.llvm.org/D116267



More information about the llvm-commits mailing list