[PATCH] D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl".

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/COFF/Writer.cpp:1505
+    // Or the program will be crash sometimes.
+    if (sec->header.Characteristics == 0 && sec->name.contains(".voltbl")) {
+      sec->header.Characteristics |= IMAGE_SCN_CNT_INITIALIZED_DATA |
----------------
I'd prefer to have this either be `sec->name == ".voltbl"` or `sec->name.startswith(".voltbl")` instead, to make it a bit more strict still.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116474/new/

https://reviews.llvm.org/D116474