[PATCH] D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl".

Sat Jan 1 05:33:56 PST 2022

gmh5225 added a comment.

In D116474#3215654 <https://reviews.llvm.org/D116474#3215654>, @mstorsjo wrote:

> This would need a test case for it to be commitable.
>
> I don’t want the linker to blindly change the characteristics bits for any section that have the bits set to zero - if this is needed for a specific section in some case, then please limit the workaround to exactly that section name and nothing else. It would be good to give more context about what tool that produces such faulty sections, and ideally that tool would be fixed too. If possible, it could be good to limit the workaround to mingw mode, if that’s where this occurs.
>
> Also, when uploading diffs, please create the diffs with extra context (`git diff -U999`).

Thanks sir. I need some time to do some test cases

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116474/new/

https://reviews.llvm.org/D116474