[PATCH] D108371: [LAA] Add Memory dependence remarks.

[Malhar via Phabricator via llvm-commits]

malharJ added inline comments.


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2149
+
+    // Emit detailed remarks for each unsafe dependence
+    DebugLoc SourceLoc;
----------------
fhahn wrote:
> Is this true? Unless I miss something, this emits a remark for the first unsafe dependence?
you are correct, the comment is no longer correct. I've updated it now in the new function.


================
Comment at: llvm/test/Transforms/LoopVectorize/memory-dep-remarks.ll:121
+entry:
+  %cmp.not19 = icmp slt i32 %n, 4
+  br i1 %cmp.not19, label %for.cond.cleanup, label %for.body.preheader
----------------
fhahn wrote:
> Is this needed? Same for other tests.
Can you please explain why this is not needed ?


================
Comment at: llvm/test/Transforms/LoopVectorize/memory-dep-remarks.ll:126
+  %sub = add nsw i32 %n, -3
+  %0 = zext i32 %sub to i64
+  br label %for.body
----------------
fhahn wrote:
> is this needed?
thanks. removed it now. changed the type of %n from i32 to i64.


================
Comment at: llvm/test/Transforms/LoopVectorize/memory-dep-remarks.ll:264
+!1 = !DIFile(filename: "source.c", directory: "")
+!2 = !{}
+!4 = !{i32 2, !"Debug Info Version", i32 3}
----------------
fhahn wrote:
> can the debug lock be trimmed down a bit?
Done.

- Changed functions to use same parameters (and same ordering).
  This helped reduce !DISubroutineType metadata.

- Also reduced some !DILocation (that were not required) from 
  test_forwardButPreventsForwarding_dep()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108371/new/

https://reviews.llvm.org/D108371