[PATCH] D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/emit-llvm_assertion_failture.ll:1
+; Make sure that if --plugin-opt=emit-llvm is enabled and the output
+; is /dev/null, it should not cause a assertion failure in bitcode writer.
----------------
`;;`


================
Comment at: lld/test/ELF/lto/emit-llvm_assertion_failture.ll:1
+; Make sure that if --plugin-opt=emit-llvm is enabled and the output
+; is /dev/null, it should not cause a assertion failure in bitcode writer.
----------------
MaskRay wrote:
> `;;`
Use `-` as filename separator

Suggest: move the RUN line and the comment into `emit-llvm.ll`. No need for a new test file.


================
Comment at: lld/test/ELF/lto/emit-llvm_assertion_failture.ll:15
+}
+
----------------
delete trailing blank line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112297/new/

https://reviews.llvm.org/D112297