[PATCH] D116180: [InstrProf] Add single byte coverage mode

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D116180#3214466 <https://reviews.llvm.org/D116180#3214466>, @ellis wrote:

> In D116180#3214457 <https://reviews.llvm.org/D116180#3214457>, @MaskRay wrote:
>
>> I know that you have posted many patches in this area and regular reviewers (e.g. davidxl, vsk) are not involved.
>> It is a holiday season for many folks so some may not be active.
>> For some intrusive/significant changes worth getting attention from them before committed, even after you get approval from your colleague(?).
>
> Makes sense to me because I posted this just before the holidays. I can hold off landing this and the previous patch until around the second week of January (I'm taking most of next week off anyway).

Thanks! They do not subscribe to these changes so they may not even know. (perhaps you mentioned the Differential links on some thread on llvm-dev, but it is pretty easy to miss this piece of information.)
I know that prudently picking reviewers is not easy: you need to do some `git log` archaeology who contributed/reviewed code in the area and may likely have an opinion.
I remember that they both commented on a previous proposal from you, so they likely have an opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116180/new/

https://reviews.llvm.org/D116180