[PATCH] D107193: [Zorg] Don't delete test-suite source directory every time.

[Galina via Phabricator via llvm-commits]

gkistanova added a comment.

> In addition to be "not set", the clean property can also be "false". Should this count as "set"?

Sorry for not being clear. With "not set" I meant "anything that evaluates to false", and with "set" I meant "anything that evaluates to true". But you have figured that out.

> The Web UI has a feature to rebuild, where "clean" and "clean_obj" can be set to true or force by clicking the checkbox

Yes, Web UI has its limitations. Web UI is not the only way we can specify build properties, though.

> However, I was only referring to getLLVMBuildFactoryAndPrepareForSourcecodeSteps itself.

Yes, that makes sense. I just pointed for other readers that it passes the given `cleanBuildRequested` to the `LLVMBuildFactory` for later use on the steps related to build and install to handle the cleaning properly.

> How would you implement not deleting the llvm-test-suite git checkout at every run?

You already have that in `getPollyBuildFactory`. And for `getOpenMPCMakeBuildFactory` you are after something similar to https://reviews.llvm.org/rZORG5ba5d2e80969. That should cover your immediate need, unless I'm missing something.

While you are at this, you may also want to add handling for `cleanBuildRequested` and conditionally remove `testsuite_builddir` in the both `OpenMPBuilder.py` and `PollyBuilder.py`.

I agree, the names `cleanBuildRequested` and `cleanBuildRequestedByProperty` are not so great. Not sure the `cleanBuildRequested` and `cleanObjRequested` are much better, though, since `cleanBuildRequested` changes semantic. Anyway, if you want, please feel free to propose NFC patch that renames everywhere. This would help keeping the names consistent. Or I'll do this when I'll have a chance.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107193/new/

https://reviews.llvm.org/D107193