[PATCH] D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files.

[Jack Andersen via Phabricator via llvm-commits]

jackoalan added a comment.

Actually, I just thought of a possible limitation of using path-append when suffixing with something that isn't actually a path component. However, I cannot say how critical this limitation is.

  -Wl,-rpath,<CFGDIR>,foo.o

This will cause a trailing `/` to be inserted after `<CFGDIR>`. However, since `<CFGDIR>` is guaranteed to be a directory, a trailing slash should not be harmful in most cases.

The primary motivation of using path-append is to tidy cases that would otherwise expand as `dir//file`. Although most practical filesystems handle paths with empty components gracefully, `vfs::InMemoryFileSystem` does not.

Weighing these two issues, I still think it is worth using path-append.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115604/new/

https://reviews.llvm.org/D115604