[PATCH] D115604: [Support] Expand `<CFGDIR>` as the base directory in configuration files.

[Jack Andersen via Phabricator via llvm-commits]

jackoalan marked an inline comment as done.
jackoalan added inline comments.


================
Comment at: llvm/lib/Support/CommandLine.cpp:1099
+    else
+      llvm::sys::path::append(ResponseFile, LHS);
+    ResponseFile.append(BasePath);
----------------
sepavloff wrote:
> What happens if `<CFGDIR>` is used without trailing path? Such line:
> ```
>     --sysroot=<CFGDIR> -abc
> ```
>  would be processed correctly?
Yes, `if (!Remaining.empty())` handles this case. I've added more test coverage for varying expansion contexts.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115604/new/

https://reviews.llvm.org/D115604