[PATCH] D110057: [LoopFlatten] Move it to a LoopPassManager

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 30 01:49:32 PST 2021


SjoerdMeijer added a comment.

I would like to pick this up, have reread the comments, but it's still a bit unclear to me what needs doing at this point.

First, returning to @nikic comment:

> Possibly it already preserves everything properly and just needs to report that it does? Plus report the deleted loop to the pass manager?

Yeah, I think so, just wanted to confirm this: it uses `forgetLoop` from `ScalarEvolution` and `markLoopAsDeleted` from the `LPMUpdater` to invalidate the old loops, and updates the DomTree with `deleteEdge`.

So does this mean that this patch is fine as it is? Modulo "the report the deleted loop to the pass manage" perhaps, will need to look into that. 
Can you please advise @nikic , @asbirlea ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110057/new/

https://reviews.llvm.org/D110057



More information about the llvm-commits mailing list