[PATCH] D116350: [RISCV] Modification of RVV CSR test file
Xinlong Wu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 29 22:42:15 PST 2021
VincentWu added a comment.
In D116350#3212017 <https://reviews.llvm.org/D116350#3212017>, @craig.topper wrote:
> In D116350#3212010 <https://reviews.llvm.org/D116350#3212010>, @VincentWu wrote:
>
>> Whether Vector CSRs should be allowed to be accessed when V extensions are not enabled?
>>
>> I mean, is there a wrong implementation or a wrong test case?
>
> I found this patch where the F extension check was removed from fcsr, fflags, and frm based on binutils not checking. https://reviews.llvm.org/D58932 But it looks like binutils may have implemented checking after that patch https://sourceware.org/legacy-ml/binutils/2019-12/msg00222.html
I think we should make Vector ext same as F extensions.
make CSRs can be accessed without V ext.
So I think this patch is make sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116350/new/
https://reviews.llvm.org/D116350
More information about the llvm-commits
mailing list