[PATCH] D116362: [TTI] Support ScalableVectorType in getShuffleCost with SK_Broadcast kind

[JunMa via Phabricator via llvm-commits]

junparser added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:876
 
     switch (improveShuffleKindFromMask(Kind, Mask)) {
     case TTI::SK_Broadcast:
----------------
junparser wrote:
> spatel wrote:
> > Can we assert that the Type is Fixed unless the shuffle is a broadcast?
> >   assert((ImprovedKind == TTI::SK_Broadcast || isa<FixedVectorType>(Tp)) && "Unexpected shuffle of scalable vector");
> yes，we can.
hmm, we cannot assert here, SK_ExtractSubvector and such kind handle scalable vector as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116362/new/

https://reviews.llvm.org/D116362