[PATCH] D112297: [LTO] Fix assertion failed when flushing bitcode incrementally for LTO output.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/test/ELF/lto/emit-llvm_assertion_failure.ll:7
+; RUN: opt -module-hash -module-summary %s -o %t.o
+; RUN: ld.lld --plugin-opt=emit-llvm -mllvm -bitcode-flush-threshold=0 -o /dev/null %t.o
+
----------------
ld.lld has very little to do with this LTO regression. It'd be good to use llvm-lto2 or llvm-lto to test this, not ld.lld


================
Comment at: llvm/lib/Support/raw_ostream.cpp:651
+  // MSVCRT's _lseek(SEEK_CUR) doesn't return -1 for pipes.
+  SupportsSeeking = !EC && IsRegularFile;
 #else
----------------
Why not `SupportsSeeking = !EC && IsRegularFile;` for non-Windows as well?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112297/new/

https://reviews.llvm.org/D112297