[PATCH] D116353: [docs][llvm-profdata] Prefer double-dash long options

Snehasish Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 29 15:28:57 PST 2021


snehasish added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-profdata.rst:61
 
-.. option:: -output=output, -o=output
+.. option:: --output=<output>, -o
 
----------------
MaskRay wrote:
> snehasish wrote:
> > -o=<output> 
> > 
> > to keep it consistent with the old documentation, also the dangling -o looks off.
> (Thanks for review:) )
> 
> I try to avoid `-o=<value>` because it is odd (see D104889).
> 
> Omitting the value name for the short option is a style used by other tools like 
> https://llvm.org/docs/CommandGuide/llvm-objcopy.html
Thanks for the pointer and clarification. Makes sense to keep it consistent with the other tools. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116353/new/

https://reviews.llvm.org/D116353



More information about the llvm-commits mailing list