[PATCH] D116367: [ELF][LTO] --thinlto-index-only: call madvise(MADV_DONTNEED)

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 29 10:49:36 PST 2021


MaskRay added a comment.

BTW: I have refactored how --start-lib is handled recently. LazyObjFile has been removed. The --start-lib style parsing for `BitcodeFile` is now in `BitcodeFile::parseLazy`.
It still uses `saver.save(sym.getName())`. There are two further improvements:

- `BitcodeFile::parseLazy` and `BitcodeFile::parse` should use the same string (backed by `saver`)
- In `createBitcodeSymbol`, if `objSym.getName()` is a stable string, we can remove `saver.save` from `StringRef name = saver.save(objSym.getName());`. This will avoid wastes for symbol names.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116367/new/

https://reviews.llvm.org/D116367



More information about the llvm-commits mailing list