[PATCH] D113741: [RFC][DwarfDebug][AsmPrinter] Support emitting function-local declaration for a lexical block
Kristina Bessonova via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 28 16:13:05 PST 2021
krisb added a comment.
In D113741#3211123 <https://reviews.llvm.org/D113741#3211123>, @shchenz wrote:
> In D113741#3210838 <https://reviews.llvm.org/D113741#3210838>, @dblaikie wrote:
>
>> In D113741#3210175 <https://reviews.llvm.org/D113741#3210175>, @shchenz wrote:
>>
>>> To continue with a more accurate fix, one example for your reference. (The behavior is changed with/without this reversion):
>>
>> Sorry, I'm not following this comment ^ (& the rest) - could you rephrase if there's a question/concern you have I can help clarify/describe/work with you on?
>
> I guess there will be a follow-up patch for the function-local declaration for lexical block? This patch seems like a reversion of a previous functionality change?
> In our internal test, we also found an issue related to variables in the lexical block, so I pasted it here for reference : )
This is the functional change itself, reverting patch is at https://reviews.llvm.org/D116225.
> Without this patch:
I guess you meant without the revert, and actually _with_ this patch, right?
If so, you'd need a clang side change https://reviews.llvm.org/D113743 (which has been reverted as well) to see static locals placed correctly.
If to apply all the reverted patches (D114705 <https://reviews.llvm.org/D114705>, D113741 <https://reviews.llvm.org/D113741>, and D113743 <https://reviews.llvm.org/D113743>) I believe you should see a correct DWARF compiled for your example.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113741/new/
https://reviews.llvm.org/D113741
More information about the llvm-commits
mailing list