[PATCH] D116331: Documentation for the process of adding new targets

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 28 12:59:26 PST 2021


rengolin added a comment.

In D116331#3211517 <https://reviews.llvm.org/D116331#3211517>, @nickdesaulniers wrote:

> LGTM; thanks for adding this. Reading through https://llvm.org/docs/DeveloperPolicy.html#adding-a-new-target, consider adding these numbered points under the bulleted list of points under `The basic rules for a back-end to be upstreamed in experimental mode are:`.

IIRC it was numbered on the original patch but we changed to bullets. I'll leave this to another patch, as I'm not sure they should be numbered either.



================
Comment at: llvm/docs/DeveloperPolicy.rst:820
+5. Some patches may be approved before others, but only once *all* patches are
+   approved that the whole set can be merged in one go. This is to guarantee
+   that all changes are good as a single block.
----------------
nickdesaulniers wrote:
> s/that/then/
I changed to "only after", which I think is what was more confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116331/new/

https://reviews.llvm.org/D116331



More information about the llvm-commits mailing list