[PATCH] D116304: [VPlan] Add abstract base class for header phi recipes (NFC).

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 28 06:40:44 PST 2021


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1117
+  VPValue *getIncomingValue(unsigned I) { return getOperand(I); }
+};
+
----------------
Ayal wrote:
> Leave getIncomingValue() in VPWidenPHIRecipe, for VPlan native? It seems to complement getIncomingBlock() and addIncoming(), and is synonymous with getOperand(),,,
Thanks, I moved it back  to `VPWidenPHIRecipe` in the committed version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116304/new/

https://reviews.llvm.org/D116304



More information about the llvm-commits mailing list