[PATCH] D116322: [Analysis] allow caller to choose signed/unsigned when computing constant range

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 28 06:22:17 PST 2021


spatel added a comment.

In D116322#3211291 <https://reviews.llvm.org/D116322#3211291>, @nikic wrote:

> LGTM. I implemented something similar in https://reviews.llvm.org/D59668 and then dropped it because my implementation was broken and my immediate need went away :)

Thanks - I didn't remember that patch, but yes, it's very close to this.

Our exhaustive unit testing has matured since then, so it shouldn't be too hard to implement. I'll look at that as a follow-up. I'd like to get this in to avoid the crashing bug.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116322/new/

https://reviews.llvm.org/D116322



More information about the llvm-commits mailing list