[PATCH] D116304: [VPlan] Add abstract base class for header phi recipes (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 28 02:37:46 PST 2021


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

Looks good to me, with a last nit.



================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1117
+  VPValue *getIncomingValue(unsigned I) { return getOperand(I); }
+};
+
----------------
Leave getIncomingValue() in VPWidenPHIRecipe, for VPlan native? It seems to complement getIncomingBlock() and addIncoming(), and is synonymous with getOperand(),,,


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116304/new/

https://reviews.llvm.org/D116304



More information about the llvm-commits mailing list