[PATCH] D116243: [CodeView] Clamp Frontend version
Di Mo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 26 17:12:07 PST 2021
modimo added a comment.
In D116243#3209390 <https://reviews.llvm.org/D116243#3209390>, @aganea wrote:
> LGTM, thanks!
Thanks for reviewing.
> I guess you could do `4.0.2021.1223` if you want the version to be properly stamped?
Trying out with `-DLLVM_VERSION_PATCH=2021.1223` I'm only seeing 14.0.2021 showing up in versioning so it looks like the rest of the compiler needs to be plumbed through to support full date stamping. I think we can change how we stamp internally (say just month/date) knowing now that the field is restricted to 16-bits. Out of curiosity do you know if S_COMPILE3 requires each version field to be 16-bits or can it be larger?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116243/new/
https://reviews.llvm.org/D116243
More information about the llvm-commits
mailing list