[PATCH] D116093: [ELF] Avoid referencing SectionBase::repl after ICF

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 24 02:30:44 PST 2021


ikudrin accepted this revision.
ikudrin added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/ELF/InputSection.cpp:952-953
       // section defining the referenced symbol is garbage collected,
       // sym.getOutputSection() is nullptr. `ds->section->repl != ds->section`
       // catches the ICF folded case. However, resolving a relocation in
       // .debug_line to -1 would stop debugger users from setting breakpoints on
----------------
The comment has to be updated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116093/new/

https://reviews.llvm.org/D116093



More information about the llvm-commits mailing list