[lld] a2baf63 - [ELF] Simplify SymbolTable::insert. NFC

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 23 17:59:34 PST 2021


Author: Fangrui Song
Date: 2021-12-23T17:59:25-08:00
New Revision: a2baf634a1d70c7909bd81189c167c3c194dee96

URL: https://github.com/llvm/llvm-project/commit/a2baf634a1d70c7909bd81189c167c3c194dee96
DIFF: https://github.com/llvm/llvm-project/commit/a2baf634a1d70c7909bd81189c167c3c194dee96.diff

LOG: [ELF] Simplify SymbolTable::insert. NFC

Added: 
    

Modified: 
    lld/ELF/SymbolTable.cpp

Removed: 
    


################################################################################
diff  --git a/lld/ELF/SymbolTable.cpp b/lld/ELF/SymbolTable.cpp
index a501b270010b..88e62507e893 100644
--- a/lld/ELF/SymbolTable.cpp
+++ b/lld/ELF/SymbolTable.cpp
@@ -70,11 +70,8 @@ Symbol *SymbolTable::insert(StringRef name) {
     stem = name.take_front(pos);
 
   auto p = symMap.insert({CachedHashStringRef(stem), (int)symVector.size()});
-  int &symIndex = p.first->second;
-  bool isNew = p.second;
-
-  if (!isNew) {
-    Symbol *sym = symVector[symIndex];
+  if (!p.second) {
+    Symbol *sym = symVector[p.first->second];
     if (stem.size() != name.size())
       sym->setName(name);
     return sym;


        


More information about the llvm-commits mailing list