[PATCH] D116225: Revert "[DwarfDebug] Support emitting function-local declaration for a lexical block" & dependent patches

Thu Dec 23 16:04:12 PST 2021

dblaikie added a comment.

In D116225#3208839 <https://reviews.llvm.org/D116225#3208839>, @krisb wrote:

> In D116225#3208579 <https://reviews.llvm.org/D116225#3208579>, @dblaikie wrote:
>
>> Thanks for giving this a go. Apparently there were some lingering failures from that precursor patch ( 0ac75e82fff93a80ca401d3db3541e8d1d9098f9 <https://reviews.llvm.org/rG0ac75e82fff93a80ca401d3db3541e8d1d9098f9> ) you're reverting here as well, so that's good. I'm happy to try applying/testing the next reapplication attempt once you/we've worked out the kinks.
>>
>> Do you think this is ready to commit? I do see some auto-test failures, but if I'm reading them right, they're that generic failure about the go bindings I see all the time (at least locally - I guess I don't have some go pieces installed) and probably not related to this patch?
>
> I have local lldb build & tests just finished without issues, so, yes, this should be ready for land.

Thanks! (sorry about missing the formal approval earlier)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116225/new/

https://reviews.llvm.org/D116225