[PATCH] D115973: [llvm-profgen] Support symbol loading for debug fission

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:48
+    DWPPath("dwp", cl::init(""), cl::ZeroOrMore,
+            cl::desc("Path of split dwarf .dwp/.dwo/.o file."));
+
----------------
There is one DWP file. There could be multiple .o/.dwo files in multiple directories. I don't think this option makes sense for the latter. The path to those should be encoded in DWARF CUs.
Also for DWP it's not exactly a path, but fully resolved path+filename
auto Obj = object::ObjectFile::createObjectFile(
          this->DWPName.empty()
              ? (DObj->getFileName() + ".dwp").toStringRef(DWPName)
              : StringRef(this->DWPName));


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115973/new/

https://reviews.llvm.org/D115973