[PATCH] D116220: [AIX][XCOFF][NFC] add some helper function for the XCOFFDumper.cpp

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 23 07:45:47 PST 2021


DiggerLin created this revision.
DiggerLin added a reviewer: jhenderson.
Herald added a subscriber: rupprecht.
DiggerLin requested review of this revision.
Herald added subscribers: llvm-commits, MaskRay.
Herald added a project: LLVM.

Addressed the comments in the https://reviews.llvm.org/D82549, including

1. changed file name from llvm/test/tools/llvm-readobj/XCOFF/xcoff-auxiliary-header.test --> llvm/test/tools/llvm-readobj/XCOFF/auxiliary-header.test
2. replaced macro define by using lambda function.
3. added a helper function to reduce the duplicated check and print error code.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D116220

Files:
  llvm/test/tools/llvm-readobj/XCOFF/auxiliary-header.test
  llvm/test/tools/llvm-readobj/XCOFF/xcoff-auxiliary-header.test
  llvm/tools/llvm-readobj/Opts.td
  llvm/tools/llvm-readobj/XCOFFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D116220.396027.patch
Type: text/x-patch
Size: 27966 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211223/1091fd60/attachment.bin>


More information about the llvm-commits mailing list