[PATCH] D116105: [AArch64] Add a tablegen pattern for SQXTN2.

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 23 05:57:57 PST 2021


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:4382
+// SQXTN2 patterns with reversed min/max
+def : Pat<(v16i8 (concat_vectors
+                 (v8i8 V64:$Vd),
----------------
Please add a comment describing the pattern that we are matching would be good, like the patterns above (it would help with reading "magic constants" VImm7F etc.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116105/new/

https://reviews.llvm.org/D116105



More information about the llvm-commits mailing list