[PATCH] D116213: [ARM] fix bug causing shrinkwrapping not always being off using PAC

Mikhail Maltsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 23 05:37:58 PST 2021


miyuki added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMFrameLowering.cpp:1814
   // generated. A follow-up patch will fix this in a more performant manner.
   if (MF.getInfo<ARMFunctionInfo>()->shouldSignReturnAddress(
+          true /*SpillsLR */))
----------------
Can we use `MF.getInfo<ARMFunctionInfo>()->shouldSignReturnAddress()` instead (i.e. base the decision on whether or not the function actually spills LR)? Or is there a pass later in the pipeline that can transform the function in such a way that it starts spilling LR?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116213/new/

https://reviews.llvm.org/D116213



More information about the llvm-commits mailing list