[PATCH] D116104: [VE] Add VE support to update_llc_test_checks

Thu Dec 23 02:05:05 PST 2021

simoll added inline comments.

================
Comment at: llvm/utils/UpdateTestChecks/asm.py:170
+ASM_FUNCTION_VE_RE = re.compile(
+    r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?'
+    r'(?P<body>^##?[ \t]+[^:]+:.*?)\s*'
----------------
kaz7 wrote:
> Do you ever seen this `(?:\s*\.?Lfunc_begin[^:\n]*:\n)?[^:]*?` in the output?
> 
> I'm thinking that specifying only `r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@(?P=func)\n'` is good enough for us.
I regenerated some tests with the shorter regex and it works fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116104/new/

https://reviews.llvm.org/D116104