[PATCH] D115965: [DSE] Fix a case of invalid dead store elimination
Marianne Mailhot-Sarrasin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 22 13:23:10 PST 2021
mamai added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1215
+ if (auto *I = dyn_cast<Instruction>(Ptr))
+ return I->getParent()->isEntryBlock();
return true;
----------------
nikic wrote:
> The code structure in this function no longer makes sense. Please rewrite the whole function to first strip offsets / GEP and then do a single entry block check.
Sorry, I just saw your comment after comiting. I could change it, but should I open a new differential for that ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115965/new/
https://reviews.llvm.org/D115965
More information about the llvm-commits
mailing list