[PATCH] D115965: [DSE] Fix a case of invalid dead store elimination

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 22 12:49:52 PST 2021


nikic added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1215
+      if (auto *I = dyn_cast<Instruction>(Ptr))
+        return I->getParent()->isEntryBlock();
       return true;
----------------
The code structure in this function no longer makes sense. Please rewrite the whole function to first strip offsets / GEP and then do a single entry block check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115965/new/

https://reviews.llvm.org/D115965



More information about the llvm-commits mailing list