[PATCH] D115965: [DSE] Fix a case of invalid dead store elimination

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 22 11:16:10 PST 2021


fhahn added a comment.

In D115965#3206906 <https://reviews.llvm.org/D115965#3206906>, @mamai wrote:

> In D115965#3206891 <https://reviews.llvm.org/D115965#3206891>, @fhahn wrote:
>
>> Thanks for the update! After addressing the final comments for the test, could you pre-commit the test (with check lines generated using `llvm/utils/update_test_checks.py` and then update this patch to just show the impact of your fix?
>
> Do you mean making a first commit with the test case (with the store missing, so that it pass) and the this patch will contain the fix and add the missing store in the test case ?

exactly


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115965/new/

https://reviews.llvm.org/D115965



More information about the llvm-commits mailing list