[PATCH] D115965: [DSE] Fix a case of invalid dead store elimination

[Florian Hahn via Phabricator via llvm-commits]

fhahn added a comment.

Thanks for the update! After addressing the final comments for the test, could you pre-commit the test (with check lines generated using `llvm/utils/update_test_checks.py` and then update this patch to just show the impact of your fix?



================
Comment at: llvm/test/Transforms/DeadStoreElimination/store-after-loop.ll:7
+
+; There is no dead store in this test. Make sure no store is deleted by DSE.
+
----------------
Could you also reference the bug report as PR52774? Could also be included in the file name.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/store-after-loop.ll:9
+
+; CHECK-LABEL: @test(
+; CHECK:       loop1:
----------------
This is a case where auto-generating the check lines with `llvm/utils/update_test_checks.py` would be helpful.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/store-after-loop.ll:43
+
+loop2:
+  %gep.list.next.next = getelementptr inbounds %struct.ilist, %struct.ilist* %list.next, i32 0, i32 1
----------------
nit: this is not a loop any more :)

Also, this probably doesn't need to be in separate BB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115965/new/

https://reviews.llvm.org/D115965