[PATCH] D116140: [AMDGPU] Add agpr_count to metadata and AsmParser

[Jacob Lambert via Phabricator via llvm-commits]

lamb-j marked 3 inline comments as done.
lamb-j added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:1158
+      if (Ctx) {
+        MCSymbol * const Sym = Ctx->getOrCreateSymbol(Twine(".kernel.agpr_count"));
+        Sym->setVariableValue(MCConstantExpr::create(AgprIndexUnusedMin, *Ctx));
----------------
arsenm wrote:
> Formatting and weird consta placement
The const does seem to be unnecessary. Should I remove from lines 1134 and 1144 as well, or leave that for another patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116140/new/

https://reviews.llvm.org/D116140