[PATCH] D116140: [AMDGPU] Add agpr_count to metadata and AsmParser

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:1158
+      if (Ctx) {
+        MCSymbol * const Sym = Ctx->getOrCreateSymbol(Twine(".kernel.agpr_count"));
+        Sym->setVariableValue(MCConstantExpr::create(AgprIndexUnusedMin, *Ctx));
----------------
Formatting and weird consta placement


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:1162
+        // Also update vgpr_count, which is dependent on agpr_count (on gfx908, gfx90a)
+        MCSymbol * const vSym = Ctx->getOrCreateSymbol(Twine(".kernel.vgpr_count"));
+        vSym->setVariableValue(MCConstantExpr::create(getTotalNumVgprs(), *Ctx));
----------------
Ditto


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:1179
+      return alignTo(VgprIndexUnusedMin, 4) + AgprIndexUnusedMin;
+  }
+
----------------
Fallthrough here for other targets


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116140/new/

https://reviews.llvm.org/D116140