[PATCH] D113741: [RFC][DwarfDebug][AsmPrinter] Support emitting function-local declaration for a lexical block

Wed Dec 22 08:00:25 PST 2021

dblaikie added a comment.

In D113741#3206529 <https://reviews.llvm.org/D113741#3206529>, @krisb wrote:

> In D113741#3205306 <https://reviews.llvm.org/D113741#3205306>, @dblaikie wrote:
>
>> Alrighty, got an A/B comparison with/without this patch (but still not reduced to share) - seems we end up creating a second split unit for one of the imported units under ThinLTO, which is incorrect (because Split DWARF only really supports one CU per split unit - so having two in a single dwo file is broken - at least if you're going to package the file with dwp, which we do).
>>
>> Looking into it further/trying to get a reduced example.
>
> (trying to guess the issue by keywords...)
>
> Is the issue about a function-local import?
>
> The only diff in imported entities handling I see is that we no longer skip emission of local imports under 'includeMinimalInlineScopes()' (which was the case before this patch, but it seems I missed this fact).
> Can it be a hidden issue revealed by this mistake?
>
> P.S. I'll fix 'includeMinimalInlineScopes()' for local import.

Yep, I'm certainly seeing some function-local imports in the test case I'm investigating, and that sounds related to be sure. Can't guarantee it's the precise issue, but I'll keep poking around at it & having a fix for the local import under minimal-inline-scopes would be good to have in any case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113741/new/

https://reviews.llvm.org/D113741