[PATCH] D114631: [DebugInfo][InstrRef] Turn instruction referencing on by default for x86

[Jeremy Morse via Phabricator via llvm-commits]

jmorse added a comment.

Hmmm. I thought this was quiet after landing -- and it turns out the reason why is there's still a sneek-circuit in clang that's turning instruction referencing off by default. Woe is me; should have done more end-to-end testing :|. On the upside, in the last few weeks LTO and non-clang frontends have had instruction referencing on, so it hasn't been completely worthless.

I'm going to drop in a patch removing the bit of clang that's turning this off again, on the "obvious fix" principle that that's what this patch was supposed to do. I'll also include in the commit message that ideally rG3c045070882f <https://reviews.llvm.org/rG3c045070882f3f43135da6a40ef3f6508fe43af6> should be reverted rather than the follow-up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114631/new/

https://reviews.llvm.org/D114631