[PATCH] D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience

[Shivam Gupta via Phabricator via llvm-commits]

xgupta added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll:7
+
+define dso_local void @foo(i32* %p) noinline nounwind optnone {
+; CHECK-LABEL: foo:
----------------
spatel wrote:
> Remove dso_local, noinline, nounwind?
After removing the noinline attribute I am getting 

```
-- Testing: 1 tests, 1 workers --
FAIL: LLVM :: CodeGen/RISCV/optnone-store-no-combine.ll (1 of 1)
******************** TEST 'LLVM :: CodeGen/RISCV/optnone-store-no-combine.ll' FAILED ********************
Script:
--
: 'RUN: at line 2';   /home/xgupta/llvm/llvm-project/build/bin/llc -mtriple=riscv64 -verify-machineinstrs < /home/xgupta/llvm/llvm-project/llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll | /home/xgupta/llvm/llvm-project/build/bin/FileCheck /home/xgupta/llvm/llvm-project/llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll
--
Exit Code: 2

Command Output (stderr):
--
Attribute 'optnone' requires 'noinline'!
void (i32*)* @foo
llc: error: '<stdin>': input module cannot be verified
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /home/xgupta/llvm/llvm-project/build/bin/FileCheck /home/xgupta/llvm/llvm-project/llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll

--

********************
********************
Failed Tests (1):
  LLVM :: CodeGen/RISCV/optnone-store-no-combine.ll


Testing Time: 1.67s
  Failed: 1
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115808/new/

https://reviews.llvm.org/D115808