[PATCH] D115997: [RISCV] Support strict FP conversion operations.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 22 05:07:47 PST 2021


luismarques added a comment.

Is it out of scope of this patch to check the rounding mode metadata argument? I've checked that changing the r.m. in a test case of e.g. fptrunc doesn't do anything, it just keeps emitting an fcvt with dynamic rounding. It's probably a good idea to add a short note describing the status/limitations of that to the tests / code / commit message, as appropriate.

Nit: is there any reason for not using a hard-float ABI in the tests? It seems like we could cut down on the loads/conversion noise in the tests. This probably also applies to D115680 <https://reviews.llvm.org/D115680>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115997/new/

https://reviews.llvm.org/D115997



More information about the llvm-commits mailing list