[PATCH] D116108: [unittest][DebugInfo/DWARF] Do not report skipped tests as passed

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added a comment.

In D116108#3205038 <https://reviews.llvm.org/D116108#3205038>, @dblaikie wrote:

> Looks like an acceptable incremental improvement, but perhaps it could be improved further if the generator be setup in the `SetUp` function and failing that function could implicitly skip tests covered by it, and similar for other tests/setup operations like initializing the MachineRegisterInfo, etc?

TBH, I do not see much profit in that change. Only `DWARFExpressionCopyBytesTest` and `DWARFExpressionCompactPrinterTest` can be easily updated, but they already have one common test method each, so moving the check into a setup method would not be a visible improvement. Other places pass custom parameters to the initializer, so reorganizing them requires much more effort, but the outcome would be elusive.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116108/new/

https://reviews.llvm.org/D116108