[PATCH] D116148: [MemoryLocation] Don't require nocapture in getForDest()

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 22 02:14:54 PST 2021


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/DeadStoreElimination/trivial-dse-calls.ll:210
+; (which is unused) or written into the dead out parameter.
+define void @test_unrelated_capture() {
+; CHECK-LABEL: @test_unrelated_capture(
----------------
> The capture can only be in the return value
  
There is no return value in the test :)

Should we add a variant of the test where either the first argument is not local or there's a return value? I guess in both cases we won't remove for non-capture related reasons, but still might be good to have here for completeness


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116148/new/

https://reviews.llvm.org/D116148



More information about the llvm-commits mailing list