[PATCH] D116036: [Inline][X86] Avoid inlining if it would create ABI-incompatible calls (PR52660)

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.
Herald added a subscriber: ChuanqiXu.

The fix seems good. Just two concerns here:

- I wonder what's the algorithm when inlining. Given we have a calling chain A->B->C. If we can inline both B and C into A, is B inlined firstly to A, then C to AB, or C inlined firstly to B, then BC to A? I'd worry if we are pessimistic for the former case.
- Another concern is the compiling time. Scanning seems inevitable, but can we avoid to repeat scanning if the inlined function is called in many place?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116036/new/

https://reviews.llvm.org/D116036