[PATCH] D116106: [unittest][DebugInfo/DWARF] Check that dwarfgen::Generator is created
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 21 23:31:43 PST 2021
ikudrin added inline comments.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp:48
+ ASSERT_THAT_EXPECTED(ExpectedGenerator, Succeeded());
+ Gen.reset(ExpectedGenerator->release());
+ }
----------------
dblaikie wrote:
> Side note, as a separate change perhaps (though don't mind if it's in this one really) this should be:
> ```
> Gen = std::move(*ExpectedGenerator);
> ```
Sure, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116106/new/
https://reviews.llvm.org/D116106
More information about the llvm-commits
mailing list