[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

[Joao Moreira via Phabricator via llvm-commits]

joaomoreira added inline comments.


================
Comment at: llvm/lib/Target/X86/X86IndirectBranchTracking.cpp:124
+  default:
+    return (F.hasAddressTaken() || !F.hasLocalLinkage());
+  }
----------------
xiangzhangllvm wrote:
> Not sure what the action if a function both has local and external call.
> Can this be replace with "hasExternalLinkage" ?
This is remaining from the same logic which was in place before this patch. Still, in my understanding, it cannot be replaced by "hasExternalLinkage" as static functions may have their address taken and still have local linkage.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116070/new/

https://reviews.llvm.org/D116070