[PATCH] D116011: [Clang] Own the CommandLineArgs in CodeGenOptions

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: clang/lib/Driver/Job.cpp:390-392
   Argv.push_back(nullptr);
+  Argv.pop_back(); // The terminating null element shall not be part of the
+                   // slice (main() behavior).
----------------
If we push `nullptr` and then pop it right after that, why do we push it in the first place?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116011/new/

https://reviews.llvm.org/D116011