[PATCH] D116031: [ArgPromotion][TTI] Pass types to ABI compatibility hook

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 21 09:33:02 PST 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds OK. Another possibility might be splitting the operations - one to test function compatibility (eg: the subtarget AVX checks in x86) and another to test a particular arg/return type. This would mean more virtual calls (one for each type instead of a batch - well, the API could still take ArrayRef for cases where you already have multiple types in a buffer) but wouldn't require allocating a new buffer to fill with types to then pass in? But maybe the number's usually low, so the buffer creation overhead isn't high?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116031/new/

https://reviews.llvm.org/D116031



More information about the llvm-commits mailing list