[PATCH] D115113: [InstCombine] Do not combine atomic and non-atomic loads.

[Sanjay Patel via Phabricator via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM. We could move some of the cosmetic diffs ("const" etc) into D116086 <https://reviews.llvm.org/D116086> or another pre-commit, but this seems fine too.



================
Comment at: llvm/test/Transforms/InstCombine/phi.ll:550-551
 
+; Atomic and non-atomic loads should not be combined.
+define i32 @PR51435(i32* %ptr, i32* %atomic_ptr, i1 %c) {
+; CHECK-LABEL: @PR51435(
----------------
Please pre-commit this test to 'main' with a FIXME comment, so we have a record of the bug in a regression test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115113/new/

https://reviews.llvm.org/D115113