[PATCH] D116039: [X86] Combine reduce (add (mul x, y)) to VNNI instruction.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:41812
 
+static SDValue createDP(SelectionDAG &DAG, const SDValue &Ext0,
+                        const SDValue &Ext1, unsigned &LogBias, const SDLoc &DL,
----------------
createVPDPBUSD ?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:42108
 
+static SDValue combineVNNIPattern(SDNode *Extract, SelectionDAG &DAG,
+                                  const X86Subtarget &Subtarget) {
----------------
Should this be called combineVPDPBUSDPattern? VNNI is the ISA no?


================
Comment at: llvm/test/CodeGen/X86/dpbusd.ll:4
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vnni | FileCheck %s --check-prefixes=AVX512VNNI
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx512vnni -mattr=+avx512vl | FileCheck %s --check-prefixes=AVX512VLVNNI
+
----------------
You might be able to use a common prefix for some of these to reduce check duplication


================
Comment at: llvm/test/CodeGen/X86/dpbusd.ll:6
+
+define dso_local i32 @no_dpbusd(i8 *%a, i8 *%b, i32 %c, i32 %n) {
+; AVXVNNI-LABEL: no_dpbusd:
----------------
Drop dso_local?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116039/new/

https://reviews.llvm.org/D116039